Fixing textarea value changes not showing

[GreenGremlin]

For a textarea value change to be displayed the value attribute must be updated, however textarea elements do not have a "value" entry in their attributes NamedNodeMap. This change ensures the value attribute is always considered for textarea elements.

[GreenGremlin]

It looks like this issue only happens the second time you apply a diff to a dom tree containing a textarea. I've added a test that covers the issue.

[johanneswilm]

@GreenGremlin This looks good. When you say that it only happens the second time, are you talking about one specific browser? Have you tested in the other browsers?

[GreenGremlin]

I've seen this in Chrome and IE10, but that's all I've tried it with. Ultimately textareas and innerText is unreliable, it's always preferred to use the value attribute instead.

[GreenGremlin]

Is there anything else needed for this to be merged?

[johanneswilm]

Hey,
yes, it's not clear whether your changed test can replace the original test fully. The test used to be about the value of a textarea that had changed because a user typed something it. Now it seems to be about a different in HTML structure that could also have been different initially without user input.

Have you checked that the new test fully replaces the old test on all browsers?

[GreenGremlin]

I've reversed that change. I made it before adding the new test and the change is unnecessary now.