fix: editor discard prompt doesn't save nor discard #5472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rmiller5466
changed the title
hacdias
approved these changes
Oct 17, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed the "DiscardEditorChanges" prompt didn't work at all. Cancel was the only working option. "Save" would just exit the hover without doing anything, and "Discard" would give no feedback at all, also doing nothing. After digging into this, I found that the Prompt was attempting to use the "saveAction" and "confirm" functions attached to the prompt, though this prompt was created without either of these functions being set. The additional "finishClose" method for the editor view isn't the cleanest solution, though wanted to minimize the code duplication across these 3 scenarios.
Additional Information
Introduced by both #5430 and #5329
Checklist
Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
masterbranch.