[WIP] feat(BREAKING CH.): coding cleanup and v2.0.0

[hacdias]

Breaking changes

• Previous configuration database and configuration files are not compatible.
• Old share links ARE NOT compatible with the new configuration hence not imported.
• DOES NOT have direct integration with Hugo nor Jekyll.
• DOES NOT have user-specific CSS. The admin can customize for the whole installation.
• Command runner ROOT variable is now SCOPE.
• Command runner FILE variable is now an absolute path and not relative to SCOPE.

TODOS

• fix: files header not scrolling
• add user/global rules via CLI
• Merge [WIP] feat: v2.0 frontend#46
• Merge and archive feat: v2 community#7
• Command to import old DB and Config files.
• Re-build Share Page
• Cleanup README.
• close Symlinks should not always treated as files #572: symlink should not be treated as file
• fix Disallow rules do not apply when downloading a folder #402: disallow rules are now respected
• fix: folder downloads are empty
• PERF: got slower with the new FS. Maybe don't use the userFs and create MatchRules that can take many rules as arg (variadic).
• close Rules disallow/allow in config file or globally #424: global allow/disallow rules
• FIx Copy text via shortcut don't work #594
• fix $FILE variable doesn't set properly "Before Delete" #593
• Add branding to settings
• Re-build Command Web Socket
• Make it work with just filebrowser -s /path.
• Re-build Search Web Socket
• close fix directories in search results can not be opened by click #583: dirs cannot be opened by click
• Pick new code editor
• rebuild settings
• close add option "default sort mode" #326: add default sort mode
• close Custom branding, logo/favicon, turn off github link. #420: custom branding
• Built-in HTTPS support
• Re-add Travis
• close logfile is too simple to be parsed by fail2ban etc #576: add IP on logging
• close Custom upload view/template - query #469: go.mod
• close feat: edit every file #358: edit every text file
• close Edit files without extension #314: "
• close Update README.md #568: limit the size of text files to open
• close Manage default user login/password with env var #562: closed via CLI tooling
• close Support for password changing via command line or config #381: "
• close Customizing admin credentials via config/flags #257: "
• close Admin password #435: "
• close More elegant and efficient way of user management #401: "
• close RFE: allow to set commands for events in config file #246: "
• close Merge the database and the configuration into a single config file #371: CLI tooling + unique DB + no config file
• close More flexible rights/permission scheme #502: more permissions (not by folder though, still by user)
• close User Management "Download file" rights suggestion #350: " (download perm)
• close feat: archiver 3 #567: archiver 3 implemented
• addresses LDAP & Active Directory (AD) Sync #301: Auther interface
• close POLL: do you use staticgen? #577
• close Hugo Plugin - Next Moves #77: no Hugo integration
• close User scope in relation to Hugo website root  #523: "
• close Hugo: Restrict user scope (access) to subfolder of content. Unexpected "Hugo New" behaviour. #555: "
• close Disable user submitted stylesheets #507: no per-user CSS, only global
• close Add user register page or API for adding users  #439: "signup" is a global setting
• close Configuration and database rework #489: database rework

[hacdias]

Update: decided to reuse the current Front end in Vue and update the dependencies. More here: filebrowser/frontend#46

[eine]

@hacdias, sure. I am going to publish v1.11.0 now, so that we have a stable v1 and we can move forward with v2 on master.

About the pending task named fix: Docker image, is there anything I can help test/fix?

[hacdias]

@1138-4eb release it! Thanks! I merged the frontend already so make sure not to update it on master eheh.

It's more wait to see if the Docker image works well and if the wizard builds it correctly 😄

[eine]

Well, the release stage did need some effort (because of filebrowser/docker-dev#3), but it is working ok now. Plus, the good news are that both golangci-lint and goreleaser work seamlessly when the repo is outside of GOPATH.

I created a new branch named v1 to keep possible bugfixes there. Then, I merged master/v1 to rewrite, and named it v2.

You can now:

• Forward rewrite to v2, and then merge this PR (forwarding master to v2).
• Forward master to v2 and close this PR manually.

[hacdias]

@1138-4eb thanks! I kept v1 and merged v2 into master. Although I don't feel comfortable in keeping the version 1 in a branch. It makes me feel like Python where two versions keep growing separately for no reason. We can keep it this way and eventually remove it in the future. We always will have the tags and I doubt there are any reasons to keep on v1.

[hacdias]

Soon will have a v2 released!

[eine]

So fast! Nice!

Certainly, we could remove both branches, v1 and v2, and use master only:

• v2 was just temporal, indeed.
• With v1, we need to remember that any bugfix should start from 013ddf4, which is the commit next to the tagged one (v1.11.0). That's why I think it can be helpful to keep it. If we see that no critical fixes need to be applied, we can remove it in the future.

[eine]

BTW, I tried the windows-amd64 binary and the docker image corresponding to v1.11.0. Both work as expected. However, caddy is failing because of some of the changes we did to filebrowser/dev (such as changing the linter tool). I'm going to fix it.

[hacdias]

Thanks. Don't worry about Caddy for now. Our plugins can't be downloaded right now. I set them as hidden on Caddy website until we have a workable version with 2.0. Caddy doesn't let us use dependency management with go mod so I was thinking about vendoring or something like that in the plugin. It will need a bit more thought though.

[eine]

Ok. So, I will review the Dockerfile thing. I downloaded the latest filebrowser image (v2) and it refuses to start due to some problem with the entrypoint.

[hacdias]

Yes, please do that! Also check if import command works as expected (ref https://docs.filebrowser.xyz/upgrade-from-1.x)

[eine]

After having a quick look at it, I think that we should avoid docker-entrypoint.sh. If that feature is really required, it should be integrated in the golang codebase.

[hacdias]

@1138-4eb let's continue on #600