1/ Boost SM 0.1 #11
Merged
1/ Boost SM 0.1 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
reviewed
Oct 27, 2021
| // ... | ||
| // | ||
| // TransferEvent (Started, Progress, Finished) ? | ||
| PercentComplete int |
There was a problem hiding this comment.
I'd suggest that instead of percent complete, we have two fields in in this event:
- bytes received
- total bytes
Then the UX can decide how it wants to display that information.
| // ProviderDealRejectionInfo is the information sent by the Storage Provider to the Client when it rejects a valid deal. | ||
| type ProviderDealRejectionInfo struct { | ||
| Reason string | ||
| Backoff time.Duration |
There was a problem hiding this comment.
Let's leave out the backoff time for now as I think we'll probably follow the askv2 protocol (which has a different mechanism)
| // InboundCARPath is the file-path where the storage provider will persist the CAR file sent by the client. | ||
| InboundCARPath string | ||
| // TransferURL is the URL sent by the client where the Storage Provider can fetch the CAR file from. | ||
| TransferURL string |
There was a problem hiding this comment.
I suggest we define a TransferType struct and use it here, something like
TransferType {
id string
data []byte
}
| ClientPeerID peer.ID | ||
|
|
||
| // DealDataRoot is the root of the IPLD DAG that the client wants to store. | ||
| DealDataRoot cid.Cid |
There was a problem hiding this comment.
DealDataRoot would be part of the TransferType struct
* integrate storagemarket.Provider into boost * add SectorBlocks; add DealPublisher; add OnDealSectorCommitted; add ProviderNodeAdapter * boost: add api client for cli interaction (#15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO