3/ boost: add api client for cli interaction #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
changed the title
nonsense
force-pushed
the
nonsense/boost-api-client
branch
3 times, most recently
from
783d70e to
d568c25
Compare
nonsense
force-pushed
the
nonsense/boost-api-client
branch
from
d568c25 to
fdbd9c9
Compare
dirkmc
approved these changes
Oct 28, 2021
Comment on lines
+72
to
+75
| // 1. *-api-url command line flags. | ||
| // 2. *_API_INFO environment variables | ||
| // 3. deprecated *_API_INFO environment variables | ||
| // 4. *-repo command line flags. |
There was a problem hiding this comment.
Do we need all of these? It might be simpler to just support one of them.
There was a problem hiding this comment.
We need them in some form - we need to configure boost and give the location of the service when interacting with it.
I think keeping BOOST_API_INFO with the Lotus convention is OK.
nonsense
added a commit
that referenced
this pull request
Oct 28, 2021
* integrate storagemarket.Provider into boost * add SectorBlocks; add DealPublisher; add OnDealSectorCommitted; add ProviderNodeAdapter * boost: add api client for cli interaction (#15)
nonsense
added a commit
that referenced
this pull request
Oct 28, 2021
* interfaces and types * feat/deal-execution (#12) * remove dead code * remove fund reservation * 2/ integrate storagemarket.Provider into boost (#14) * integrate storagemarket.Provider into boost * add SectorBlocks; add DealPublisher; add OnDealSectorCommitted; add ProviderNodeAdapter * boost: add api client for cli interaction (#15) Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding an RPC client for the Boost service, exposing the
api.Boostto CLI commands. Next step is to create client side command to trigger deals.