-
Notifications
You must be signed in to change notification settings - Fork 76
2/ integrate storagemarket.Provider into boost #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2/ integrate storagemarket.Provider into boost #14
Conversation
4d96c6e
to
6f745a9
Compare
6f745a9
to
8773bf3
Compare
…roviderNodeAdapter
254f442
to
af8fb77
Compare
@aarshkshah1992 @dirkmc scope here is exploding, because we can't just add a provider that references underlying interfaces that are not defined, such as: As next steps, I suggest:
a) removing WDYT? |
@nonsense I agree. Just one ask: Since we wanna keep boost lightweight, we don't wanna be porting a bunch of interfaces from Lotus to Boost. I don't see the harm in keeping them in Lotus as they are today. |
Which interfaces and structs are you referring to specifically? Everything that I have ported is markets related as far as I can tell, and the process boundary is at the fullnode API. |
* interfaces and types * feat/deal-execution (#12) * remove dead code * remove fund reservation * 2/ integrate storagemarket.Provider into boost (#14) * integrate storagemarket.Provider into boost * add SectorBlocks; add DealPublisher; add OnDealSectorCommitted; add ProviderNodeAdapter * boost: add api client for cli interaction (#15) Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
This PR is integrating the new storagemarket.Provider into the
boost
service.It also:
provider
as we need to define it in the uber.Fx dependency injection applotusNode
, which is pointing tostorageadapter.ProviderNodeAdapter
, and use directlyfullnodeApi
, which is the Lotus Fullnode API.TODO in follow up PRs:
storageadapter.ProviderNodeAdapter
from Lotus to Boost and uncomment all commented parts ofstoragemarket.Provider
- we want this in order to unite all markets logic under theboost
service roof.