Skip to content

remove flaky TestMultipleDealsConcurrentResumptionDisconnect #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2023
Merged

remove flaky TestMultipleDealsConcurrentResumptionDisconnect #1138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions storagemarket/provider_transfer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,31 +75,6 @@ func TestRetryShutdownRecoverable(t *testing.T) {
require.EqualValues(t, dealcheckpoints.Accepted, pds.Checkpoint)
}

func TestMultipleDealsConcurrentResumptionDisconnect(t *testing.T) {
logging.SetLogLevel("http-transport", "WARN") //nolint:errcheck

nDeals := 5
ctx := context.Background()
fileSize := testFileSize

// setup the provider test harness with a disconnecting server that disconnects after sending the given number of bytes
harness := NewHarness(t, withHttpDisconnectServerAfter(int64(fileSize/101)), withHttpTransportOpts([]httptransport.Option{httptransport.BackOffRetryOpt(50*time.Millisecond, 100*time.Millisecond, 2, 1000)}))
// start the provider test harness
harness.Start(t, ctx)
defer harness.Stop()

tds := harness.executeNDealsConcurrentAndWaitFor(t, nDeals, func(i int) *testDeal {
return harness.newDealBuilder(t, i, withNormalFileSize(fileSize)).withAllMinerCallsNonBlocking().withDisconnectingHttpServer().build()
}, func(_ int, td *testDeal) error {
return td.waitForCheckpoint(dealcheckpoints.AddedPiece)
})

for i := 0; i < nDeals; i++ {
td := tds[i]
td.assertPieceAdded(t, ctx)
}
}

func TestTransferCancelledByUser(t *testing.T) {
ctx := context.Background()

Expand Down