fix(action): use fileSize to determine capacity when spendrate=0 #132

Copilot · 2025-10-16T20:17:02Z

Problem

The GitHub action bot was incorrectly calculating the required payment balance as 0.0000 USDFC when there was no existing storage (rateUsed = 0) but a file upload was pending. This caused uploads to fail with the error:

insufficient funds to cover lockup after function execution

The issue manifested as:

Current Filecoin Pay balance: 0.0000 USDFC
Wallet USDFC balance: 188.7805 USDFC
Required top-up for 30 days of storage: 0.0000 USDFC
✓ No deposit required - sufficient balance available

Followed immediately by an upload failure due to insufficient funds.

Root Cause

The handlePayments function was using computeTopUpForDuration which only considers existing storage usage (rateUsed). When rateUsed = 0 (no active storage), it would return topUp: 0n even though a file requiring lockup funds was about to be uploaded. The function had no visibility into the upcoming upload's requirements.

Solution

This PR modifies the payment calculation to be file-aware when there's no existing storage:

Pass file size to payment handler: The CAR file size (available from the build phase) is now passed to handlePayments
File-aware calculation: When rateUsed = 0 and a file size is provided, the function uses computeAdjustmentForExactDaysWithFile to calculate deposit requirements that account for:
- The new file's 10-day lockup requirement
- The ongoing storage cost for the target runway period (minStorageDays)
- A 10% safety buffer
Backward compatibility: The existing computeTopUpForDuration logic is preserved for cases with active storage

Code Changes

The fix leverages the existing computeAdjustmentForExactDaysWithFile function from the payments module, which was designed for exactly this scenario but wasn't being used in the GitHub action workflow.

Testing

✅ All 157 unit tests pass (including 2 new tests for file-aware calculation)
✅ TypeScript type checking passes
✅ Linting passes
✅ No security vulnerabilities (CodeQL)

Behavior After Fix

Current Filecoin Pay balance: 0.0000 USDFC
Wallet USDFC balance: 188.7805 USDFC
Required top-up for 30 days of storage (including upcoming upload): 1.2345 USDFC
[Deposit transaction submitted]
[Upload succeeds]

The required balance is now correctly calculated based on the file size and target storage duration, ensuring sufficient funds are deposited before the upload begins.

Fixes #[issue-number]

Original prompt

This section details on the original issue you should resolve

<issue_title>Github action bot fails with payment balance check issues</issue_title>
<issue_description>note that the github action checks the balance and considers depositing funds and decides it doesn't need to No deposit required - sufficient balance available followed by error related to insufficient funds to cover lockup after function execution

━━━ Funding Phase: Checking Filecoin Pay Account ━━━
Checking current Filecoin Pay account balance...
Current Filecoin Pay balance: 0.0000 USDFC
Wallet USDFC balance: 188.7805 USDFC
Required top-up for 30 days of storage: 0.0000 USDFC
✓ No deposit required - sufficient balance available
✓ Funding phase complete
━━━ Upload Phase: Uploading to Filecoin ━━━
{"level":30,"time":1760643932319,"pid":2171,"hostname":"runnervmwhb2z","event":"payments.allowances.updated","transactionHash":"0x80c80a5d6e324a1e651e8d480d409149a961a73a73b64c6979b570e49fe16349","msg":"WarmStorage permissions configured automatically"}
{"level":30,"time":1760643932319,"pid":2171,"hostname":"runnervmwhb2z","event":"synapse.storage.create","msg":"Creating storage context"}
{"level":30,"time":1760643933172,"pid":2171,"hostname":"runnervmwhb2z","event":"synapse.storage.provider_selected","provider":{"id":3,"serviceProvider":"0xa3971A7234a3379A1813d9867B531e7EeB20ae07","name":"ezpdpz-calib","serviceURL":"https://calib.ezpdpz.net/"},"msg":"Selected storage provider"}
{"level":50,"time":1760643933906,"pid":2171,"hostname":"runnervmwhb2z","event":"synapse.storage.create.failed","error":"Failed to create data set: 500 Internal Server Error - Failed to send transaction: failed to estimate gas: message execution failed (exit=[33], revert reason=[message failed with backtrace:\n00: f0169791 (method 3844450837) -- contract reverted at 75 (33)\n01: f0169791 (method 6) -- contract reverted at 4535 (33)\n02: f0169800 (method 3844450837) -- contract reverted at 75 (33)\n03: f0169800 (method 6) -- contract reverted at 10988 (33)\n04: f0169792 (method 3844450837) -- contract reverted at 1775 (33)\n (RetCode=33)], vm error=[Error(invariant failure: insufficient funds to cover lockup after function execution)])\n","msg":"Failed to create storage context: Failed to create data set: 500 Internal Server Error - Failed to send transaction: failed to estimate gas: message execution failed (exit=[33], revert reason=[message failed with backtrace:\n00: f0169791 (method 3844450837) -- contract 
✓ Completed check run with conclusion: failure
Upload failed: Failed to create data set: 500 Internal Server Error - Failed to send transaction: failed to estimate gas: message execution failed (exit=[33], revert reason=[message failed with backtrace:
00: f0169791 (method 3844450837) -- contract reverted at 75 (33)
01: f0169791 (method 6) -- contract reverted at 4535 (33)
02: f0169800 (method 3844450837) -- contract reverted at 75 (33)
03: f0169800 (method 6) -- contract reverted at 10988 (33)
04: f0169792 (method 3844450837) -- contract reverted at 1775 (33)
 (RetCode=33)], vm error=[Error(invariant failure: insufficient funds to cover lockup after function execution)])
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
<comment_new><author>@wjmelements</author><body>

Current Filecoin Pay balance: 0.0000 USDFC
Wallet USDFC balance: 188.7805 USDFC
Required top-up for 30 days of storage: 0.0000 USDFC
✓ No deposit required - sufficient balance available

This looks wrong. The required balance should not be 0.</body></comment_new>
</comments>

Fixes #129

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: BigLep <85411+BigLep@users.noreply.github.com>

SgtPooki · 2025-10-16T20:31:18Z

Issue explanation sounds right.

BigLep · 2025-10-16T20:36:09Z

@SgtPooki : I'll let you review/merge this one when it's ready to go

SgtPooki

change is good enough.. needed to unblock some action users for their first usage.

SgtPooki · 2025-10-17T11:47:48Z

upload-action/src/filecoin.js

 * @param {any} logger - Logger instance
 * @returns {Promise<PaymentStatus>} Updated payment status
 */
 export async function handlePayments(synapse, options, logger) {


@BigLep should we allow skipping payments adjustments entirely in the gh action, and allow some folks to handle that completely outside of the action?

Sure. But maybe that can be done specifying minStorageDays as 0?

SgtPooki · 2025-10-17T11:49:50Z

upload-action/src/filecoin.js

+    const rateUsed = initialStatus.currentAllowances.rateUsed ?? 0n
+
+    // If there's an upcoming file upload and no existing usage, calculate deposit based on file size
+    if (rateUsed === 0n && carSizeBytes != null && carSizeBytes > 0) {
+      // Get pricing information to calculate file requirements
+      const storageInfo = await synapse.storage.getStorageInfo()
+      const pricePerTiBPerEpoch = storageInfo.pricing.noCDN.perTiBPerEpoch
+
+      // Calculate required deposit accounting for the new file
+      const { delta } = computeAdjustmentForExactDaysWithFile(
+        initialStatus,
+        minStorageDays,
+        carSizeBytes,
+        pricePerTiBPerEpoch
+      )
+
+      requiredTopUp = delta > 0n ? delta : 0n
+      console.log(
+        `Required top-up for ${minStorageDays} days of storage (including upcoming upload): ${formatUSDFC(requiredTopUp)} USDFC`
+      )
+    } else {
+      // Use existing logic for maintaining current usage
+      const { topUp } = computeTopUpForDuration(initialStatus, minStorageDays)
+      requiredTopUp = topUp
+      console.log(`Required top-up for ${minStorageDays} days of storage: ${formatUSDFC(requiredTopUp)} USDFC`)
+    }


We could fix this in filecoin-pin with a helper function that handles all the things under the hood.

cc @rvagg

On the surface, this seems useful to have in filecoin-pin, I agree.

the lens should be: minimal bespoke code needed in the action that's not related to dealing with being an action; if it's doing Synapse or Pin things, let's push them down

SgtPooki · 2025-10-17T11:51:31Z

upload-action/src/filecoin.js

+        initialStatus,
+        minStorageDays,
+        carSizeBytes,
+        pricePerTiBPerEpoch


we should probably be getting pricePerTiBPerEpoch internally via a util function instead of always passing it around. This will help when we eventually migrate to support withCDN payments

BigLep · 2025-10-17T18:35:39Z

@SgtPooki : thanks. I left a couple of comments. Feel free to create issues if they are things we won't just knock out quick.

Initial plan

040ba0b

Copilot AI assigned Copilot and BigLep Oct 16, 2025

Copilot started work on behalf of BigLep October 16, 2025 20:17 View session

Copilot AI and others added 2 commits October 16, 2025 20:27

Fix payment balance calculation to account for upcoming file uploads

889c606

Co-authored-by: BigLep <85411+BigLep@users.noreply.github.com>

Apply linting fixes to test file

c077cfa

Co-authored-by: BigLep <85411+BigLep@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix payment balance check issues in GitHub action~~ Fix payment balance calculation to account for upcoming file uploads Oct 16, 2025

Copilot AI requested a review from BigLep October 16, 2025 20:35

Copilot finished work on behalf of BigLep October 16, 2025 20:35

BigLep requested a review from SgtPooki October 16, 2025 20:35

BigLep marked this pull request as ready for review October 16, 2025 20:36

BigLep changed the title ~~Fix payment balance calculation to account for upcoming file uploads~~ fix(action): fix payment balance calculation to account for upcoming file uploads Oct 16, 2025

SgtPooki changed the title ~~fix(action): fix payment balance calculation to account for upcoming file uploads~~ fix(action): use fileSize to determine capacity when spendrate=0 Oct 17, 2025

SgtPooki approved these changes Oct 17, 2025

View reviewed changes

SgtPooki merged commit f498169 into master Oct 17, 2025
23 of 24 checks passed

SgtPooki deleted the copilot/fix-payment-check-errors branch October 17, 2025 11:56

github-actions bot mentioned this pull request Oct 17, 2025

chore(master): release 0.9.2 #133

Merged

This was referenced Oct 20, 2025

feat: allow skipping payments adjustments in the gh action #141

Open

fix: reduce bespoke code in filecoin-pin/upload-action #142

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(action): use fileSize to determine capacity when spendrate=0 #132

fix(action): use fileSize to determine capacity when spendrate=0 #132

Uh oh!

Copilot AI commented Oct 16, 2025 •

edited

Loading

Uh oh!

SgtPooki commented Oct 16, 2025

Uh oh!

BigLep commented Oct 16, 2025

Uh oh!

SgtPooki left a comment

Uh oh!

SgtPooki Oct 17, 2025

Uh oh!

BigLep Oct 17, 2025

Uh oh!

SgtPooki Oct 17, 2025

Uh oh!

BigLep Oct 17, 2025

Uh oh!

rvagg Oct 20, 2025

Uh oh!

SgtPooki Oct 17, 2025

Uh oh!

Uh oh!

BigLep commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

fix(action): use fileSize to determine capacity when spendrate=0 #132

fix(action): use fileSize to determine capacity when spendrate=0 #132

Uh oh!

Conversation

Copilot AI commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Root Cause

Solution

Code Changes

Testing

Behavior After Fix

Uh oh!

SgtPooki commented Oct 16, 2025

Uh oh!

BigLep commented Oct 16, 2025

Uh oh!

SgtPooki left a comment

Choose a reason for hiding this comment

Uh oh!

SgtPooki Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

BigLep Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

SgtPooki Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

BigLep Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

rvagg Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

SgtPooki Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BigLep commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Oct 16, 2025 •

edited

Loading