fix: check ipni advertisement during upload #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilOzzy
added
team/filecoin-pin
SgtPooki
force-pushed
the
137-action-check-filecoinpincontactcidcid-before-showing-ipfs-mainnet-retrieval-urls
branch
from
0ba8701 to
7d4303d
Compare
SgtPooki
commented
Oct 30, 2025
| const uploadResult = await executeUpload(synapseService, carData, rootCid, { | ||
| logger, | ||
| contextId: `${contextType}-${Date.now()}`, | ||
| ipniValidation: { enabled: false }, |
There was a problem hiding this comment.
we are not displaying ipfs gateway urls in CLI currently, so we disable it here.
BigLep
added this to the
M3.5: Filecoin Service Liftoff: Filecoin Onchain Cloud launch milestone
BigLep
removed this from the
M3.5: Filecoin Service Liftoff: Filecoin Onchain Cloud launch milestone
There was a problem hiding this comment.
Pull Request Overview
This PR adds IPNI (InterPlanetary Network Indexer) validation to the upload flow, ensuring that uploaded content is announced and discoverable on the IPFS network before displaying IPFS gateway URLs. The validation is enabled by default but can be disabled when needed.
- Introduces a new
validateIPNIAdvertisementutility that pollsfilecoinpin.contactto verify IPFS CID announcements - Integrates IPNI validation into the upload execution flow, with the validation starting after upload completion
- Updates output display logic to show "Waiting for IPNI announcement" instead of preview URLs when validation is pending
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/core/utils/validate-ipni-advertisement.ts |
New utility function that polls IPNI with retry logic and progress callbacks |
src/core/utils/types.ts |
New type definitions for progress events and handlers |
src/core/utils/index.ts |
Exports the new IPNI validation utility |
src/core/upload/index.ts |
Integrates IPNI validation into the upload flow with configurable options |
src/test/unit/validate-ipni-advertisement.test.ts |
Comprehensive test coverage for IPNI validation behavior |
upload-action/src/types.ts |
Adds ipniValidated boolean to the upload result interface |
upload-action/src/upload.js |
Threads ipniValidated field through the upload action flow |
upload-action/src/outputs.js |
Conditionally displays gateway URLs based on IPNI validation status |
upload-action/src/filecoin.js |
Configures IPNI validation with progress callbacks and removes fallback preview URL |
src/common/upload-flow.ts |
Explicitly disables IPNI validation for this flow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* fix(ci): handle duplicate items in add-to-project workflow Add continue-on-error to prevent workflow failure when an issue/PR already exists in the project board. The actions/add-to-project action does not currently handle this case gracefully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix(ci): only run workflow when team/fs-wg label is added Add conditional to prevent workflow from running on every labeled event. Now it only runs when the specific 'team/fs-wg' label is added, avoiding duplicate runs when multiple labels are added at once. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
* Explicitly declare direct dep rather than rely on synapse * cdn endEpoch removed from ds info * 10 day grace period => 30 day grace period * fix: plumb --warm-storage-address through `payments setup` * fix: check lockup period during allowance check * chore: update to synapse@next tag, fix test failures & update more lockup mismatches * post rebase wip * Update synapse to v0.35.0 * Make things compile with add piece and create all in one * chore: fix onPieceAdded txHash * fix test --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
…before-showing-ipfs-mainnet-retrieval-urls
SgtPooki
deleted the
137-action-check-filecoinpincontactcidcid-before-showing-ipfs-mainnet-retrieval-urls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds first-class IPNI announcement validation to filecoin-pin core and wires it into the GitHub Action:
ipniValidatedis true.Follow-up: The CLI improvements in #169 will switch to consume this core method and its onProgress callback instead of rolling its own polling, and switch the CLI default of ipniValidation to
enabled: true.Fixes #137
References: