Skip to content

Conversation

@dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Mar 29, 2021

Fixes #177

@dirkmc dirkmc requested a review from nonsense March 29, 2021 10:11
@codecov-io
Copy link

Codecov Report

Merging #181 (6eb5bfc) into fix/pull-on-complete-timeout (5ced066) will increase coverage by 0.30%.
The diff coverage is 90.90%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           fix/pull-on-complete-timeout     #181      +/-   ##
================================================================
+ Coverage                         65.31%   65.61%   +0.30%     
================================================================
  Files                                24       24              
  Lines                              2462     2484      +22     
================================================================
+ Hits                               1608     1630      +22     
+ Misses                              518      517       -1     
- Partials                            336      337       +1     
Impacted Files Coverage Δ
channelmonitor/channelmonitor.go 78.49% <90.90%> (-0.53%) ⬇️
impl/events.go 73.06% <0.00%> (+0.73%) ⬆️
network/libp2p_impl.go 74.78% <0.00%> (+3.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ced066...6eb5bfc. Read the comment docs.

Base automatically changed from fix/pull-on-complete-timeout to master March 30, 2021 12:00
@dirkmc
Copy link
Contributor Author

dirkmc commented Apr 16, 2021

Superseded by #193

@dirkmc dirkmc closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect pausing in data transfer channel data-rate monitors

4 participants