Support no-op error responses #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
fails CI. Is there known flakiness in the Channel Monitor tests ? |
2 tasks
Contributor
Yes, that's a known issue, we can safely ignore 👍 |
dirkmc
reviewed
Apr 1, 2021
This was referenced Apr 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For filecoin-project/go-fil-markets#528.
@dirkmc
As discussed, we need to add support for
go-fil-marketsto return anErrNoOpin addition toErrPause&ErrResumeso data transfer can maintain the status quo instead of resuming/pausing the data transfer to avoid races with thego-fil-marketsresuming data transfer in the state machine thread.