Fix pause on restart #199
Merged
Fix pause on restart #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
fix/pause-on-restart
branch
from
c36f1f6 to
c202f91
Compare
dirkmc
force-pushed
the
fix/pause-on-restart
branch
from
c202f91 to
29bfef7
Compare
aarshkshah1992
approved these changes
May 4, 2021
Contributor
aarshkshah1992
left a comment
aarshkshah1992
left a comment
There was a problem hiding this comment.
@dirkmc Some quick questions. Otherwise LGTM.
| if !restartAgain { | ||
| // No restart queued, we're done | ||
| if mc.cfg.OnRestartComplete != nil { | ||
| mc.cfg.OnRestartComplete(mc.chid) |
Contributor
There was a problem hiding this comment.
I don't see this getting configured/injected anywhere. What's the purpose of this ?
Contributor
Author
There was a problem hiding this comment.
This is just used by the tests
| if _, ok := t.requestorCancelledMap[chid]; ok { | ||
| _, ok := t.requestorCancelledMap[chid] | ||
| t.dataLock.Unlock() | ||
| if ok { |
Contributor
There was a problem hiding this comment.
Woah. Great catch man ! This could have been causing hairy deadlock issues ...
Contributor
Author
There was a problem hiding this comment.
Yeah I think it actually has caused some deadlock issues, I suspect once we release we'll see a bunch of weird problems go away.
dirkmc
added a commit
that referenced
this pull request
May 6, 2021
* feat: add isRestart param to validators * fix: on restart dont unpause unstarted transfer (#199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a restart, and the data transfer hasn't yet started (eg because the data is still being unsealed) the new graphsync request should start off in the paused state