Skip to content

Log closing of completion channel #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Log closing of completion channel #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a8b079
log closing of completion channel
aarshkshah1992 Aug 17, 2021
bd8a620
fix ci
aarshkshah1992 Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ commands:
- when:
condition: << parameters.linux >>
steps:
- run: sudo apt-get update
- run: sudo apt-get update --allow-releaseinfo-change
- run: sudo apt-get install ocl-icd-opencl-dev
build-all:

Expand Down
6 changes: 5 additions & 1 deletion transport/graphsync/graphsync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,10 @@ func (t *Transport) consumeResponses(responseChan <-chan graphsync.ResponseProgr
// Read from the graphsync response and error channels until they are closed
// or there is an error, then call the channel completed callback
func (t *Transport) executeGsRequest(req *gsReq) {
defer req.onComplete()
defer func() {
log.Infow("gs request complete for channel", "chid", req.channelID)
req.onComplete()
}()

lastError := t.consumeResponses(req.responseChan, req.errChan)

Expand Down Expand Up @@ -885,6 +888,7 @@ func (c *dtChannel) open(ctx context.Context, chid datatransfer.ChannelID, dataS
// completes (or is cancelled)
completed := make(chan struct{})
onComplete := func() {
log.Infow("closing the completion ch for data-transfer channel", "chid", chid)
close(completed)
}
c.completed = completed
Expand Down