Log completion message flow #236
Conversation
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 67.70% 67.77% +0.06%
==========================================
Files 24 24
Lines 3044 3050 +6
==========================================
+ Hits 2061 2067 +6
Misses 627 627
Partials 356 356
Continue to review full report at Codecov.
|
| msg, err := m.completeMessage(chid) | ||
| if err != nil { | ||
| return nil | ||
| return err |
There was a problem hiding this comment.
Is this changed on purpose? I see everything else is log lines, apart from this.
There was a problem hiding this comment.
This needs an explanation, as it introduces a change in behaviour.
There was a problem hiding this comment.
Hey,
The error returned from here is only logged and we take no action based on it. If there's an error while creating the complete message, we do want to know about it.
| msg, err := m.completeMessage(chid) | ||
| if err != nil { | ||
| return nil | ||
| return err |
There was a problem hiding this comment.
This needs an explanation, as it introduces a change in behaviour.
@raulk This is to debug the "Timed out waiting for complete message" issue.