improve graphsync transport logging #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
- Coverage 67.90% 67.76% -0.14%
==========================================
Files 24 24
Lines 3050 3053 +3
==========================================
- Hits 2071 2069 -2
- Misses 624 628 +4
- Partials 355 356 +1
Continue to review full report at Codecov.
|
transport/graphsync/graphsync.go
Outdated
| for range req.responseChan { | ||
| } | ||
| for err := range errChan { | ||
| log.Debugf("channel %s: finished consuming graphsync response channel", req.channelID) |
Contributor
There was a problem hiding this comment.
This can be Info as it's just for an entire transfer.
transport/graphsync/graphsync.go
Outdated
| for err := range req.errChan { | ||
| lastError = err | ||
| } | ||
| log.Debugf("channel %s: finished consuming graphsync error channel", req.channelID) |
Contributor
There was a problem hiding this comment.
Info as just once for an entire transfer.
aarshkshah1992
approved these changes
Aug 23, 2021
Contributor
aarshkshah1992
left a comment
aarshkshah1992
left a comment
There was a problem hiding this comment.
Please merge after addressing the comments.
dirkmc
force-pushed
the
feat/gs-tpt-logging
branch
from
a85af07 to
13fcc80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.