Refactor sim package in prep for expanding the implementation
#171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/sim-refactor-prep
branch
from
6aaa31d to
37e5481
Compare
Kubuxu
approved these changes
Apr 23, 2024
Break up large go files into separate ones that capture minimal functionality. Encapsulate simulated signing related implementations into their own package, called `signing`. Rename inconsistent struct/constructor names, and resolve minor lint issues. Note, the changes here do not make any net functional difference. Instead, they aim to reduce the LOC changed in successive PRs where simulation will be expanded to accommodate more complex scenarios, including more control over adversary message propagation, latency and message loss modeling.
masih
force-pushed
the
masih/sim-refactor-prep
branch
from
37e5481 to
79ea60b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break up large go files into separate ones that capture minimal functionality. Encapsulate simulated signing related implementations into their own package, called
signing.Rename inconsistent struct/constructor names, and resolve minor lint issues.
Note, the changes here do not make any net functional difference. Instead, they aim to reduce the LOC changed in successive PRs where simulation will be expanded to accommodate more complex scenarios, including more control over adversary message propagation, latency and message loss modeling.