Ignore equivocating and duplicate messages from a sender #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
May 10, 2024
| // create an aggregate for these prefixes. | ||
| // This is intended for use in the QUALITY phase. | ||
| // Ignores any subsequent values from a sender from which a value has already been received. | ||
| func (q *quorumState) ReceiveEachPrefix(sender ActorID, values ECChain) { |
Member
There was a problem hiding this comment.
Did you mean to use this? Or is this for a future patch?
Member
Author
There was a problem hiding this comment.
Thanks, good catch. A call to this replaces the similar code in the QUALITY_PHASE case in receieveOne.
anorth
force-pushed
the
anorth/drop-equivs
branch
from
0333ba7 to
3d9b613
Compare
anorth
force-pushed
the
anorth/drop-equivs
branch
from
3d9b613 to
0014efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153