Skip to content

Conversation

@masih
Copy link
Member

@masih masih commented May 15, 2024

Change make test target to measure code coverage in atomic mode, and extend CI test workflow to upload the reports to Codecov.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@masih
Copy link
Member Author

masih commented May 15, 2024

Once this PR is merged to main we should start seeing the reports.

@masih masih requested review from Kubuxu, Stebalien and anorth May 15, 2024 11:30
@Kubuxu
Copy link
Contributor

Kubuxu commented May 15, 2024

Let's ensure that codecov build status is marked as not required until we tune the settings (it can be fiddly).

@Kubuxu
Copy link
Contributor

Kubuxu commented May 15, 2024

I would also move coverage collection to separate make target as collecting coverage has non-insignificant perf hit.

Change `make test` target to measure code coverage in atomic mode, and
extend CI test workflow to upload the reports to Codecov.
@masih masih force-pushed the masih/add-codecov-report branch from 3d41ef4 to f486a7a Compare May 15, 2024 14:25
@masih
Copy link
Member Author

masih commented May 15, 2024

Let's ensure that codecov build status is marked as not required until we tune the settings (it can be fiddly).

Sure; it is not.

I would also move coverage collection to separate make target as collecting coverage has non-insignificant perf hit.

Done.

@Kubuxu Kubuxu added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 92ee9a8 May 15, 2024
@Kubuxu Kubuxu deleted the masih/add-codecov-report branch May 15, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants