Add more parallelism to tests in t.Run() #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
force-pushed
the
anorth/test-parallel
branch
from
25d0734 to
3fa8627
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage 71.63% 71.63%
=======================================
Files 31 31
Lines 2337 2337
=======================================
Hits 1674 1674
Misses 533 533
Partials 130 130 |
|
Fuzz test failed on commit 25d0734. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 9182151072 -n testdataAleternatively, download directly from here. |
Stebalien
approved these changes
May 22, 2024
masih
approved these changes
May 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Fuzz test failed on commit 1a831d4. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 9182236551 -n testdataAleternatively, download directly from here. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: until #262 is fixed and we can enable parallelism in
TestHonestMultiInstance_Agreement, this only saves 3s.ORIGINAL:
On my modern MBP with
-parallel=8this gives an improvement of 54s -> 21s.A little more is possible, but see #262.