Remove redundant weak quorum flag from chain support #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous iterations of FIP-0086 made use of weak quorum in chain state, but the latest changes no longer require it. The only place that the notion of weak quorum is used is in skipping to future rounds, where it is only needed at quorum state. Hence the unused code removal at chain support. Fixes #233
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 85.33% 85.48% +0.15%
==========================================
Files 14 14
Lines 1459 1454 -5
==========================================
- Hits 1245 1243 -2
+ Misses 136 133 -3
Partials 78 78
|
Stebalien
approved these changes
Jun 5, 2024
Kubuxu
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous iterations of FIP-0086 made use of weak quorum in chain state, but the latest changes no longer require it. The only place that the notion of weak quorum is used is in skipping to future rounds, where it is only needed at quorum state. Hence the unused code removal at chain support.
Fixes #233