Fix race condition in honest tests #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/rece-condition-honest-test
branch
from
7813d38 to
0865235
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 84.99% 84.99%
=======================================
Files 14 14
Lines 1486 1486
=======================================
Hits 1263 1263
Misses 139 139
Partials 84 84 |
Kubuxu
approved these changes
Jun 7, 2024
Kubuxu
reviewed
Jun 7, 2024
Kubuxu
requested changes
Jun 7, 2024
Contributor
Kubuxu
left a comment
Kubuxu
left a comment
There was a problem hiding this comment.
I think it works right now but it is not guaranteed to
Avoid modifying test case options during parallel test execution.
masih
force-pushed
the
masih/rece-condition-honest-test
branch
from
0865235 to
6206fb3
Compare
Kubuxu
approved these changes
Jun 7, 2024
Contributor
Kubuxu
left a comment
Kubuxu
left a comment
There was a problem hiding this comment.
append on an empty array expression is how I usually saw it done but LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid modifying test case options during parallel test execution.