Fix tipset stringer max print limit and refine ec chain stringer #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where tipset stringer would panic if its length is less than 16 bytes. Refine `ECChain` stringer to skip building the string value if max length is reached, instead of fully build then truncate.
masih
force-pushed
the
masih/echchain-stringer-fix
branch
from
d733afd to
8cccd2c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 83.14% 83.16% +0.01%
==========================================
Files 15 15
Lines 1774 1776 +2
==========================================
+ Hits 1475 1477 +2
Misses 174 174
Partials 125 125
|
Kubuxu
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where tipset stringer would panic if its length is less than 16 bytes.
Refine
ECChainstringer to skip building the string value if max length is reached, instead of fully build then truncate.