Skip to content

Conversation

@Terryhung
Copy link
Collaborator

@Terryhung Terryhung commented Feb 11, 2023

Issue #788

Description

The json returned by lily job list should include current height for walk, watch and gapfill jobs.

Approach

Add the currentHeight in Reporter, then pass the Reporter to Watcher, Walker and Filler. Therefore, they can update the currentHeight during job execution. Finally, we could see the current height for walk, watch and gapfill jobs.

@Terryhung Terryhung marked this pull request as ready for review February 11, 2023 18:50
@frrist frrist self-requested a review February 11, 2023 19:20
@Terryhung Terryhung requested a review from frrist February 12, 2023 16:09
Copy link
Member

@frrist frrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once comments are addressed.

@Terryhung Terryhung merged commit 10608e8 into master Feb 14, 2023
@Terryhung Terryhung deleted the terryhung/add-currentheight-to-command branch February 14, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants