allow blocksync to sync messages #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ```go | ||
| type BlockSyncRequest struct { | ||
| Start Cid | ||
| Start []Cid |
Contributor
There was a problem hiding this comment.
can you add a comment that this means the tipset, otherwise not really clear
dignifiedquire
approved these changes
May 10, 2019
network-protocols.md
Outdated
| ``` | ||
|
|
||
| The response contains the chain of requested blocks, in reverse iteration order, the zero'th block should be the block referenced by `request.Start`, and the following N blocks should be its N parents, and so on. This is done to streamline validation. | ||
| The response contains the requested chain in reverse iteration order. Each item in the `Chain` array is contains the blocks for that tipset if the `Blocks` option bit in the request was set, and if the `Messages` bit was set, the messages across all blocks in that tipset. The `MsgIncludes` array contains one array of integers for each block in the `Blocks` array. Each of the arrays in `MsgIncludes` contains a list of indexes of messages from the `Messages` array that are in each `Block` in the blocks array. |
Contributor
There was a problem hiding this comment.
"is contains" is really hard to parse
Contributor
There was a problem hiding this comment.
might be good to have a tiny example to make sure it is clear how this indexing works
Blocks: [b0, b1]
Messages: [m0, m1, m2]
MsgIncludes: [[0, 1], [1, 2, 0]]
matches to
Block 0: [m0, m1]
Block 1: [m1, m2, m0]
Member
Author
|
feedback addressed and merged! |
This was referenced May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.