Skip to content

Code Quality: Broader SidebarView control usage #15283

@0x5bfa

Description

@0x5bfa

Description

We're planning to use SidebarView in order to keep consistency across the application.

Concerned code

  • Around SidebarView class

Gains

Consistency and simplicity

Requirements

This work appears to be huge, so I suggest to break down to a few phases as below:

  1. Move SidebarViewModel code to MainPageViewModel
  2. Use DependencyProperties
  3. Add FrameworkElement for icon to models
  4. Add AnimatedIcon's state change in SidebarItem's visual states
  5. Separate Sidebar controls to Files.App.Controls. Essentially separate implementations for specific scenarios.

Comments

None

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

Status

📋 Planning stage

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions