Bug: Files uses incorrect size unit mappings

[dongle-the-gadget]

Description

Related to #10075, opening as a separate issue as this is a bug and not a feature.

Previously found in #16882, Files uses incorrect size unit mappings, as it internally calculates sizes in base-two (so the appropriate units are kibibytes, mebibytes, etc.) but it shows to the user base-ten units (kilobytes, megabytes) instead.

This causes a disparity in the screenshot of #16882 where Files UI determined that 1007 GB is smaller than 1 TB, so it showed the size in GB rather than TB.

Relevant code:

Files/src/Files.App/Data/Models/ByteSize.cs

Line 10 in 283345a

private static readonly FrozenDictionary<string, string> units = new Dictionary<string, string>

Steps To Reproduce

See screenshot in #16882.

Files Version

Found on main branch, might have affected released versions

Windows Version

Not relevant

User ID

No response

Log File

Not relevant

[yaira2]

Thank you for the report

[dongle-the-gadget]

@yaira2 I saw that you moved it to "Ready to build", however I don't think we have enough specifics yet. Should we move calculations to base-ten or change the units to base-two?

[yaira2]

We may want to make it an option in the future, but for now, I feel that base-ten is more common. What are your thoughts?

[dongle-the-gadget]

Base-10 would give us the least friction when it comes to localization, as we are already localized in base-10 (although I don't think there's much to localize units anyways)

[yaira2]

Let's go with Base-10