Bug: Selecting a shortcut in a git folder crashes Files

[wuyilingwei]

Description

Trying to click/select a link file in any way will cause the entire program to crash and restart.
This is the command in link file. Used to convert pictures in the same directory to webp through ffmpeg

C:\Windows\System32\cmd.exe /C for %i in (*.jpg *.png *.jpeg) do ffmpeg -i "%i" "%~ni.webp"

Steps To Reproduce

1. Create a new shortcut and fill in the above command
2. Any attempt to select this file in files will result in a crash.(no need running)

Files Version

3.9.1.0

Windows Version

10.0.22631.5039

User ID

9a9d7334-3ac0-4870-a4ae-9503d5f3c117

Log File

debug.log

[Josh65-2201]

Thanks for the report

[wuyilingwei]

I want to correct a problem, the crash occurs at the selection stage instead of opening it, and I have the details bar enabled, maybe it has something to do with this feature

[Josh65-2201]

Can you see if this is an issue in the preview version. https://files.community/download

[Liguma]

Have the same problem and it occurs in both versions.
!!! If I move the linke with win standard file explorer to another place, I can the also work with it within files !!!

[wuyilingwei]

Can you see if this is an issue in the preview version. https://files.community/download

I comform that also is an issue in the 3.9.3.0 preview version.

2025-04-02 13:21:58.9780|Information|Files.App.Launcher updated.
2025-04-02 13:22:10.9891|Error|System.InvalidCastException: Unable to cast object of type 'Files.App.Utils.GitShortcutItem' to type 'Files.App.Utils.ShortcutItem'.
   at Files.App.Utils.ListedItem.get_IsLinkItem()
   at Files.App.Helpers.ShareItemHelpers.IsItemShareable(ListedItem item)
   at System.Linq.Enumerable.All[TSource](IEnumerable`1 source, Func`2 predicate)
   at Files.App.Actions.ShareItemAction.get_IsExecutable()
   at Files.App.UserControls.Toolbar.Toolbar_obj1_Bindings.Toolbar_obj1_BindingsTracking.PropertyChanged_Commands_ShareItem(Object sender, PropertyChangedEventArgs e)
   at Files.App.Data.Commands.ActionCommand.Action_PropertyChanged(Object sender, PropertyChangedEventArgs e)
   at CommunityToolkit.Mvvm.ComponentModel.ObservableObject.SetProperty[T](T& field, T newValue, String propertyName)
   at Files.App.Data.Contexts.ContentPageContext.UpdateSelectedItems()
   at CommunityToolkit.Mvvm.ComponentModel.ObservableObject.SetProperty[T](T& field, T newValue, String propertyName)
   at Files.App.ViewModels.UserControls.NavigationToolbarViewModel.set_SelectedItems(List`1 value)
   at Files.App.Views.Layouts.BaseLayoutPage.set_SelectedItems(List`1 value)
   at Files.App.Views.Layouts.DetailsLayoutPage.FileList_SelectionChanged(Object sender, SelectionChangedEventArgs e)
   at ABI.Microsoft.UI.Xaml.Controls.SelectionChangedEventHandler.Do_Abi_Invoke(IntPtr thisPtr, IntPtr sender, IntPtr e)
2025-04-02 13:22:12.4464|Information|App launched. Launch args type: ProtocolActivatedEventArgs

System info:
Version Windows 11 Professional
Version number 23H2
OS version 22631.5039
Experience Windows Feature Experience Pack 1000.22700.1074.0

[marcofranzen99]

i think the problem only occurs with shortcut items that are part of a git repository. i am working on a solution