Skip to content

Conversation

@cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented Feb 16, 2023

Resolved / Related Issues
This pr adds the rich command manager, and 2 basic actions. This is a first pr. Features and commands will be added step by step hotkey, glyph, context, ...)

The actions (IActions and IToggleAction) make it easy to implement a command.
The commands (IRichCommands) gives properties and methods useful to views. IRichCommand should never be implemented.

The actions ShowFileExtensions and ShowHiddenItems are already used by the menu.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 requested a review from d2dyno1 February 17, 2023 15:44
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Feb 17, 2023
@yaira2 yaira2 merged commit 27cbf73 into files-community:main Feb 17, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants