Feature: Vertical NavigationView in the properties window

[0x5bfa]

Description

I'm redesigning storage object's properties pages.

Tasks to do

• Update UI
• Add PathIcons for all of NavViewItem icons
• Format all codes that I changed
• Add new translation resources

Validation

• Built and ran the app
• Tested the changes for accessibility

Screenshots

MS-Store-like vertical NavigationView

[ferrariofilippo]

I left some comments on code style.
There are some other issues:

• You can't scroll General tab (edit. also Compatibility)
  

• Resizing the window doesn't work as expected
  

• Shortcut glyph is wrong
  

[0x5bfa]

@ferrariofilippo Thank you for reviewing however those commits were created for showing a schreenshot to discuss it is ok that we leave as it is.

[yaira2]

however this new style is quite looks bad and have some accessibility and user-experience problems.

Is it the outline icons? This will improve when I implemented the filled versions.

[0x5bfa]

Yes. if so, you have to add all of that cuz Segoe and CustomGlyph cannot be coexisted. Do you do that in this PR?

<FontIcon
    x:Name="NavigationViewItemGlyphPrimeryFontIcon"
    Margin="2,0,0,0"
    HorizontalAlignment="Center"
    x:Load="{x:Bind IsSelected, Mode=OneWay}"
    FontSize="22"
    Foreground="{ThemeResource SystemAccentColor}"
    Glyph="{x:Bind GlyphPrimary, Mode=OneWay}" />

<FontIcon
    x:Name="NavigationViewItemGlyphSecondaryFontIcon"
    Margin="2,0,0,0"
    HorizontalAlignment="Center"
    x:Load="{x:Bind IsSelected, Converter={StaticResource BoolNegationConverter}, Mode=OneWay}"
    FontSize="22"
    Foreground="{ThemeResource TextFillColorSecondaryBrush}"
    Glyph="{x:Bind GlyphSecondary, Mode=OneWay}" />

[yaira2]

I'll take care of this, can you fix the scroll issues?

[0x5bfa]

@yaira2 Scrolling problem was fixed.

[0x5bfa]

• You can't scroll General tab (edit. also Compatibility)
• Resizing the window doesn't work as expected
• Shortcut glyph is wrong(replaced Wrench icon)

[yaira2]

@onein528 does opening the properties window crash the app for you?

[0x5bfa]

I'm gonna commit 'Some fix 12' including fix that crush.

[yaira2]

Thanks! It might be good practice to make the commit names a little more descriptive.

[yaira2]

LGTM

[0x5bfa]

Wait why removed that negative margin?

[yaira2]

It was misaligned, I'm trying to find a different solution.

[0x5bfa]

Should/Can I remove unneeded controls from style in ResDictionary?

[yaira2]

It's a good idea to

[0x5bfa]

Future task lists

• Rename Pages
• Rename ViewModels (especially, PropertiesTab)
• Refactor codes in order not to use outdated terms like 'tab'
• Redesign all properties pages to fit this new design