Skip to content

Feature: Follow file extension setting for Recent Files widget #15113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2024
Merged

Feature: Follow file extension setting for Recent Files widget #15113

merged 4 commits into from
Apr 4, 2024

Conversation

@gumbarros
Copy link
Contributor

@gumbarros gumbarros commented Apr 4, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: File extensions are not displayed in Recent files widget #15108

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
  • Are there any other steps that were used to validate these changes?
    1. Check Recent Files
    2. Click settings button
    3. Folder/Files -> Toggle Show File Extensions
    4. Check Recent Files again

Screenshots
image
image

@hishitetsu hishitetsu added the ready for review Pull requests that are ready for review label Apr 4, 2024
0x5bfa
0x5bfa approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!
LGTM.

hishitetsu
hishitetsu reviewed Apr 4, 2024
View reviewed changes
@gumbarros @hishitetsu
Update src/Files.App/Utils/RecentItem/RecentItems.cs
840c72b 
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
hishitetsu
hishitetsu approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 5831ac2 into files-community:main Apr 4, 2024
@yaira2 yaira2 changed the title Fix: File extensions not showing up at Recent Files Feature: Follow file extension setting for Recent Files widget Apr 4, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Apr 4, 2024
marianalcar pushed a commit to marianalcar/Files that referenced this pull request Apr 6, 2024
@gumbarros @marianalcar
Feature: Follow file extension setting for Recent Files widget (files…
7cf76ee 
…-community#15113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

@hishitetsu hishitetsu hishitetsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: File extensions are not displayed in Recent files widget

4 participants

@gumbarros @0x5bfa @hishitetsu @yaira2