Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Introduced IStorageArchiveService #15341

Merged
merged 9 commits into from
May 22, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 9, 2024

Summary

I'd like to provide single and simple way of compression and decompression.
In this effort, I'd also like to use ILocatableStorable to identify compression folder or decompression destination instead of string path in the future.

As a sidenote, I removed all null-ref warnings in modified classes (#9895).

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. ✅ Open Files app
  2. ✅ Do Extract files
  3. ✅ Do Extract here (smart)
  4. ✅ Do Extract her
  5. ✅ Do Extract to 'folder name'
  6. ✅ Do Create archive
  7. ✅ Do Create .zip
  8. ✅ Do Create .7z

Ensured Status Center has an item for each, and decompressed/compressed file/folder name is increaded as Decompressed files (2).

@yaira2 yaira2 self-requested a review May 9, 2024 14:58
@0x5bfa 0x5bfa changed the title Code Quality: Introduced StorageArchiveService Code Quality: Introduced IStorageArchiveService May 18, 2024
@yaira2 yaira2 requested a review from hishitetsu May 21, 2024 16:47
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 22, 2024
@yaira2 yaira2 merged commit dac6a20 into files-community:main May 22, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-StorageArchiveService branch May 22, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants