Skip to content

Code Quality: Change active pane border thickness in high contrast #15482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 28, 2024
Merged

Code Quality: Change active pane border thickness in high contrast #15482

merged 14 commits into from
May 28, 2024

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented May 27, 2024 •
edited
Loading

Resolved / Related Issues

  • Increased border thickness for active pane in high contrast mode

image

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label May 27, 2024
@yaira2 yaira2 requested a review from 0x5bfa May 27, 2024 21:14
@yaira2
Copy link
Member Author

yaira2 commented May 27, 2024

This causes an issue where the border is too thick when a single pane is open in High Contrast.

@yaira2 yaira2 added the help wanted Extra attention is needed label May 27, 2024
yaira2
yaira2 commented May 27, 2024
View reviewed changes
@yaira2 yaira2 marked this pull request as draft May 27, 2024 22:11
@yaira2 yaira2 marked this pull request as ready for review May 27, 2024 22:16
@yaira2 yaira2 removed the help wanted Extra attention is needed label May 28, 2024
0x5bfa
0x5bfa reviewed May 28, 2024
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code wise.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels May 28, 2024
@yaira2 yaira2 merged commit 77d562b into main May 28, 2024
@yaira2 yaira2 deleted the ya/DualPaneBorderThickness branch May 28, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@0x5bfa 0x5bfa 0x5bfa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaira2 @0x5bfa