Code Quality: Convert Multiple Localized Strings to ICU Message Format | Stage Two #15508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Test results
|
0x5bfa
approved these changes
May 30, 2024
Member
0x5bfa
left a comment
0x5bfa
left a comment
There was a problem hiding this comment.
This is WWREALLY great!!! Code wise no problems at all
Your extension doing great job
Contributor
Author
Yes, this expansion is literally magical. |
yaira2
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.TODO list: #15503 (comment)
Stage two
☑️ DayAgo, DaysAgo ----> DaysAgo
Files/src/Files.App/Strings/en-US/Resources.resw
Lines 387 to 392 in af0ab75
☑️ HourAgo, HoursAgo ----> HoursAgo
Files/src/Files.App/Strings/en-US/Resources.resw
Lines 393 to 398 in af0ab75
☑️ MinuteAgo, MinutesAgo ----> MinutesAgo
Files/src/Files.App/Strings/en-US/Resources.resw
Lines 399 to 404 in af0ab75
☑️ OneSecondAgo, SecondsAgo ----> SecondsAgo
Files/src/Files.App/Strings/en-US/Resources.resw
Lines 405 to 410 in af0ab75