Skip to content

Code Quality: Added support for clinking links in the release notes #15545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Code Quality: Added support for clinking links in the release notes #15545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Files.App/Dialogs/ReleaseNotesDialog.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@
HorizontalScrollMode="Auto"
VerticalScrollMode="Auto">
<controls:MarkdownTextBlock
x:Name="ReleaseNotesMarkdownTextBlock"
Background="Transparent"
LinkClicked="ReleaseNotesMarkdownTextBlock_LinkClicked"
ListGutterWidth="16"
Text="{x:Bind ViewModel.ReleaseNotesMadrkdown, Mode=OneWay}" />
</ScrollViewer>
Expand Down
7 changes: 7 additions & 0 deletions src/Files.App/Dialogs/ReleaseNotesDialog.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Controls;
using Windows.System;

namespace Files.App.Dialogs
{
Expand Down Expand Up @@ -58,5 +59,11 @@ private ContentDialog SetContentDialogRoot(ContentDialog contentDialog)

return contentDialog;
}

private async void ReleaseNotesMarkdownTextBlock_LinkClicked(object sender, CommunityToolkit.WinUI.UI.Controls.LinkClickedEventArgs e)
{
if (Uri.TryCreate(e.Link, UriKind.Absolute, out Uri? link))
await Launcher.LaunchUriAsync(link);
}
}
}