Skip to content

Conversation

@hishitetsu
Copy link
Member

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Create an empty folder.
  2. Try to compress it.
  3. Now it works.

@hishitetsu hishitetsu added the ready for review Pull requests that are ready for review label Jun 4, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fixed issue where empty folders could not be compressed Fix: Fixed an issue where empty folders could not be compressed Jun 4, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jun 4, 2024
@yaira2 yaira2 merged commit 2ad172c into files-community:main Jun 4, 2024
@hishitetsu hishitetsu deleted the CompressEmptyFolder branch June 5, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Unable to compress empty folders

2 participants