Code Quality: Add Composition based speed graph #15558
Conversation
|
Does the new speed graph match the design, with the gradient brush, the positioning of the Speed value with padding above the graph to avoid overlapping, and the stroke colour adapting to theme changes? 
|
|
Right now, not at all, I'll get that fixed soon |
|
@heftymouse is this ready for review? |
|
I have to make it respond to theme changes and unhook all the event handlers, but most of it is done |
| <Grid | ||
| x:Name="MainGraphCartesianChartClipGrid" | ||
| Height="72" | ||
| Height="128" |
There was a problem hiding this comment.
Is this increased height by design?
There was a problem hiding this comment.
I put it there since it was easier to see in testing and I thought it looked nicer but it's not necessary
There was a problem hiding this comment.
I know this was discussed on Discord, what was the conclusion?
There was a problem hiding this comment.
Martin said 80 if 72 didn' look right.
And still 80 looks short to @heftymouse (me as well a bit).
There was a problem hiding this comment.
72 is what the design uses, but the height should balance out the heading padding for the speed text and the chart height.
We are not trying to match File Explorer, and we should be conscious of how tall the flyout becomes with multiple operations on-going and the expanded size.
yaira2
changed the title
yaira2
added
ready to merge
5 participants
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.