Code Quality: Reverting changes for DateTime formatting without ICU

[XTorLukas]

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• Closes Bug: Files slows to a crawl if opening a folder with lots of files (preview build) #15554

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Try loading bigger folder e.g. C:/Windows/System32
2. It is now faster to load strings with formatting using GetLocalizedFormatResource

[XTorLukas]

@yaira2 fyi

[0x5bfa]

Those are used in bulk enumeration so speed is important imo.
Do you think having our own message formatter would improve performance?

Codewise, looks good to me.

[XTorLukas]

Those are used in bulk enumeration so speed is important imo. Do you think having our own message formatter would improve performance?

According to the benchmarks I am doing while developing my own UnicodeFormatter, the results are promising so far, but I am still working on optimisation and development, here I am already running into the limits of C# and it is necessary to redirect some operations to the C++ part or use pointers in the unsafe part of the code. I will continue the development. For now, however, this MessageFormat cannot be used with a large number of elements.

[yaira2]

Hopefully we can figure this out so that we can bring back the code improvements, but the main thing is that performance is back to how it was before.