Skip to content

Conversation

@tsvietOK
Copy link
Contributor

@tsvietOK tsvietOK commented Jun 24, 2024

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files
  2. Opened folder in Details View
  3. Checked that the width of the column changes correctly according to the mouse move
  4. Checked that column width auto align function is not broken by new changes

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fixed an issue where width of the column is changing incorrectly Fix: Fixed an issue where the cursor wasn't inline when resizing Details View columns Jun 24, 2024
@yaira2 yaira2 changed the title Fix: Fixed an issue where the cursor wasn't inline when resizing Details View columns Fix: Fixed an issue where the cursor wasn't inline when resizing columns in Details View Jun 24, 2024
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 24, 2024
@yaira2 yaira2 requested a review from hishitetsu June 24, 2024 19:58
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, no problems at all.
As a side note, we should use TwoWay binding.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit ce5453a into files-community:main Jun 25, 2024
@tsvietOK tsvietOK deleted the fix-column-resize branch June 29, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Incorrectly resized column in Details View

4 participants