Code Quality: Replace OpacityIcon #15843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
force-pushed
the
ya/Icons
branch
4 times, most recently
from
8cb6fe7 to
8891800
Compare
0x5bfa
reviewed
Jul 23, 2024
|
|
||
| /// <summary> | ||
| /// Gets string glyph or opacity icon. | ||
| /// Gets string glyph or ThemedIcon style. |
| public bool CollapseLabel { get; set; } | ||
|
|
||
| public OpacityIconModel OpacityIcon { get; set; } | ||
| public ThemedIconModel ThemedIcon { get; set; } |
Member
There was a problem hiding this comment.
Could you rename this to ThemedIconModel?
| { | ||
| public struct ThemedIconModel | ||
| { | ||
| public string ThemedIconStyle { get; set; } |
Member
Author
There was a problem hiding this comment.
It causes the app to crash, let me know if you have any luck on this one.
Member
There was a problem hiding this comment.
It's ok, i was going to replace this to a class with constructor to simplify. I'll find why at that time.
src/Files.App/ViewModels/UserControls/Widgets/FileTagsWidgetViewModel.cs
Outdated
Show resolved
Hide resolved
0x5bfa
approved these changes
Jul 24, 2024
Member
0x5bfa
left a comment
0x5bfa
left a comment
There was a problem hiding this comment.
LGTM, code wise.
It would be appreciated to create MenuFlyoutItemEx (themed icon and image) instead of MenuFlyoutItemWith* in an upcoming PR.
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
This PR replaced OpacityIcon with ThemedIcon.