Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 23, 2024

Resolved / Related Issues

Reported internally, planned internally

Steps used to test these changes

  1. Open Files.sln
  2. No info bar pops up

Well, I hate sln. I want slnx seriously 😭

@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 23, 2024

@yaira2 this fixed the misconfiguration message.

@yaira2
Copy link
Member

yaira2 commented Jul 23, 2024

It still an issue on my side

@0x5bfa 0x5bfa marked this pull request as draft July 25, 2024 04:42
@0x5bfa 0x5bfa force-pushed the 5bfa/Fix-SlnConfig branch from 2fa671e to cf3710c Compare July 26, 2024 04:30
@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 26, 2024

I think now fixed. I reopened VS many times but no warnings poped up.

@0x5bfa 0x5bfa added the ready for review Pull requests that are ready for review label Jul 26, 2024
@0x5bfa 0x5bfa marked this pull request as ready for review July 26, 2024 04:31
@0x5bfa 0x5bfa force-pushed the 5bfa/Fix-SlnConfig branch from cf3710c to b90bf6b Compare July 26, 2024 04:34
@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 26, 2024

Can you rerun the CI?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jul 26, 2024
@yaira2 yaira2 merged commit 868071d into files-community:main Jul 26, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Fix-SlnConfig branch July 26, 2024 14:27
0x5bfa added a commit to 0x5bfa/Files that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants