Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Jul 24, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files (default settings)
  2. Set Files as default file manager
  3. Closed all tabs
  4. Opened Files from third party app
  5. Confirmed the correct location launched
  6. Closed all tabs
  7. Opened Files regularly
  8. Confirmed the Home Page was opened
  9. Opened a folder in Files
  10. Restarted Files and confirmed the tabs were restored

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit a93d04f into main Jul 25, 2024
@yaira2 yaira2 deleted the ya/Param branch July 25, 2024 01:50
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Home tab opened when opening file location with no active tabs and using continue where you left off startup setting.

3 participants