-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Code Quality: Document entire repository #16363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I barely know C++ so whatever I wrote is totally wrong 😭
Does it look a bit too familiar?
|
Gotta appreciate the effort. Just a nit: I read that it's unnecessary c.q. unrecommended to mix headers and formatting. |
@Jay-o-Way what do you mean? |
|
I mean using # `text`(same counts for e.g. links, which is not in this pr) |
|
Ah yes. I just used it to specify the directory. |
|
So just let you know, I disagree with this idea. No one sees Strings dir, for example. Files codebase follows a normal MVVM design pattern, anyone can understand what's in these folders. Just the source is complicated, not the structure. |
|
Maybe that's correct. |
|
Let's discuss this proposal in #16364 |
|
@yaira2 @Lamparter i think we can close this for now, we haven't made a solid decision how to document the source code. |
Similar to #15652, I've taken the time to document the entire repository.
However, unlike the previous PR, this is far less descriptive codebase documentation and so is far less likely to become outdated.
To be honest, I wonder whether this might be more viable:
That might be a good idea, but it's down to @yaira2 to express his plans for documentation.