Skip to content

Bump Appium.WebDriver from 4.4.5 to 8.0.1 #17772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Bump Appium.WebDriver from 4.4.5 to 8.0.1 #17772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
<PackageVersion Include="System.Text.Json" Version="9.0.9" />
<PackageVersion Include="System.IO.Hashing" Version="9.0.9" />
<PackageVersion Include="System.Threading.Tasks.Dataflow" Version="9.0.9" />
<PackageVersion Include="Appium.WebDriver" Version="4.4.5" />
<PackageVersion Include="Appium.WebDriver" Version="8.0.1" />
<PackageVersion Include="Axe.Windows" Version="2.4.2" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The `Appium.WebDriver` upgrade removes the WindowsElement type and FindElementBy* methods, causing compilation and runtime failures in the test suite.

  • Description: Upgrading Appium.WebDriver from version 4.4.5 to 8.0.1 introduces multiple breaking changes. The WindowsElement type, used for the driver session in SessionManager.cs and in helper methods in TestHelper.cs, was removed in version 5.0.0, which will cause the project to fail during compilation. Additionally, methods like FindElementByName, FindElementByAccessibilityId, and FindElementsByTagName were removed in version 6.0.0. These methods are still called in SessionManager.cs and TestHelper.cs to interact with UI elements. If the compilation issue were resolved, these calls would cause runtime errors, preventing tests from running.

  • Suggested fix: Replace all usages of the WindowsElement type with its modern equivalent, likely WebElement or AppiumElement. Update all calls to the removed FindElementBy* methods to use the new Selenium 4 locator strategy, for example, by using FindElement(By.Name("...")) or FindElement(AppiumBy.AccessibilityId("...")).
    severity: 0.95, confidence: 1.0

Did we get this right? 👍 / 👎 to inform future reviews.

<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
<PackageVersion Include="MSTest.TestAdapter" Version="4.0.1" />
Expand Down
Loading