Code Quality: Skip USERNAME env var when launching processes #17872
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the USERNAME environment variable from being set for child processes to avoid issues where files are executed as the SYSTEM user. Addresses problem described in issue #12139.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
0x5bfa
reviewed
Nov 16, 2025
| string key = (string)ent.Key; | ||
|
|
||
| // Skip USERNAME to avoid issues where files were executed as SYSTEM user (#12139) | ||
| if (key == "USERNAME") |
Member
There was a problem hiding this comment.
Use the ordinal case ignoring string comparison.
Member
Author
There was a problem hiding this comment.
Does it make a difference here?
Member
There was a problem hiding this comment.
== differentiates A and a but OrdinalIgnoreCase doesn't.
Member
Author
There was a problem hiding this comment.
As far as I know, this variable is always uppercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
This is a new approach to solving #12139 and replaces the solution implemented in #14101. This PR adds back the code removed in #14101 and instead skips the USERNAME environment variable when getting the Machine variables.