Fix folder copying to sibling folder with almost the same name #620
Conversation
Get other default folders locations same way
…remove space before .dll (#604) * Remove space before .dll * Add Invert Selection, fix folder navigation crash Also fixes critical bug where a folder is deleted if it's moved into itself and the user presses skip * Add multiligual resources for new string
* Prevent crash on opening new tab from folder * Prevent opening multiple new tabs from blocking the UI * Remove TabView Transition Animations * Fix Item Thumbnails not Loading * Ensure file type property is loaded
ghost
added
the
|
@tsvietOK Hi thanks for this PR. The original issue that this block of code tried to solve was users copying a folder into itself. Does this change still prevent all instances of a destination folder being a subfolder of the source folder?
|
|
@duke7553 hmmm, your right, i didn't test this case. I have to find another workaround. |
|
@tsvietOK I'll mark this as a draft for now then. |
|
Taken from https://stackoverflow.com/questions/5617320/given-full-path-check-if-path-is-subdirectory-of-some-other-path-or-otherwise |
|
@tsvietOK That looks pretty good to me |
|
@duke7553 do you have troubles with folder copying? |
|
@tsvietOK Do you want me to test this now? I can mark this as ready for review. |
|
@duke7553 If your copy function working fine, of course. |
|
@duke7553 did you tested it? |
|
@tsvietOK Can you merge with the latest from |
|
Before merging, this should be tested to make sure that the changes work in release mode. |
|
@yaichenbaum Part with subfolder detection working fine for me. Another thing, we currently don't supporting Windows's path length limit(as i understand 260 characters) |
|
@tsvietOK I would think that is a different issue, right? |
|
@yaichenbaum Yes, your right |
yaira2
added
ready to merge
To reproduce this bug create folder with name "Some Folder" and another sibling folder with name "Some Folder 1". Try to copy or move first folder in second.