Added custom cname option #186
Conversation
staturecrane
left a comment
staturecrane
left a comment
There was a problem hiding this comment.
LGTM -- made comment about README section
README.md
Outdated
|
|
||
| ### CNAME | ||
|
|
||
| CNAME is a custom add on feature that can be used along with other customization to create a seamless whitelabeled filepicker for your application. |
There was a problem hiding this comment.
I don't think the sales information should live in the GitHub -- just what they need to use CNAME if they have it set up. Could we change this to something like:
"If you have set up a custom CNAME set up, you can add it to your filestack_rails config. The Picker will modify all assets to formatted with your domain origin instead of Filestack's."
Or something like that. And then we can go into the example code.
There was a problem hiding this comment.
@staturecrane thanks for review :) I will rewrite it a little bit different.
What about CHANGELOG file? should I also write about changes with CNAME configuration?
There was a problem hiding this comment.
@gabifiolek Once the PR is merged into develop, then you can follow our wiki guidelines for release, which includes updating the CHANGELOG and version with the appropriate info.
gabifija
force-pushed
the
feature/FS-3050-cname
branch
from
1ce052c to
f9112f4
Compare
|
@staturecrane please take a look on README changes |
gabifija
force-pushed
the
feature/FS-3050-cname
branch
from
0d67322 to
59156da
Compare
No description provided.