Skip to content

Added support for more JS callbacks on file picker #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Added support for more JS callbacks on file picker #204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b3c188
Added support for more JS callbacks on file picker
zivverbit May 23, 2019
e897bcd
remove unneccessary deletion of options
zivverbit May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion app/helpers/filestack_rails/application_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def cname

def create_javascript_for_picker(callback, options)
client_name, = get_client_and_api_key
callbacks_js = build_callbacks_js(options)
json_string = if options.nil?
''
else
Expand All @@ -60,11 +61,21 @@ def create_javascript_for_picker(callback, options)

v3 = -> { json_string = "#{json_string}".slice!(1, json_string.length-2) # removed curly brackets help to generate pickerOptions in js
"(function(){
#{client_name}.picker({#{json_string}, onUploadDone: data => #{callback}(data)}).open()
#{client_name}.picker({#{json_string}, onUploadDone: data => #{callback}(data)#{callbacks_js}}).open()
})()" }
get_filestack_js_result(v2: v2, v3: v3)
end

def build_callbacks_js(options)
string = ""
string << ", onOpen: picker => #{options.delete(:onOpen)}(picker)" unless options[:onOpen].blank?
string << ", onClose: () => #{options.delete(:onClose)}()" unless options[:onClose].blank?
string << ", onFileUploadFinished: file => #{options.delete(:onFileUploadFinished)}(file)" unless options[:onFileUploadFinished].blank?
string << ", onFileSelected: file => #{options.delete(:onFileSelected)}(file)" unless options[:onFileSelected].blank?
string << ", onUploadStarted: files => #{options.delete(:onUploadStarted)}(files)" unless options[:onUploadStarted].blank?
string
end

def get_client_and_api_key
client_name = ::Rails.application.config.filestack_rails.client_name
apikey = ::Rails.application.config.filestack_rails.api_key
Expand Down