Flow type definitions aren't working

[saadq]

Are you submitting a bug report or a feature request?

Bug report

What is the current behavior?

Flow type definitions aren't working

What is the expected behavior?

Flow type definitions should work

What's your environment?

Node: v9.5.0
Flow: v0.64.0
React: v16.2.0
Final-Form: v4.2.0
React-Final-Form: v3.1.0

Steps to reproduce

1. npm install flow-bin final-form react-final-form
2. Write this code:

/**
 * @flow
 */

import { version } from 'react-final-form'

const v: number = version // This should throw error, but doesn't

console.log(v)

3. Run flow in terminal or editor

As you can see, it doesn't cause any issues:

Possible solution

I think this may have to do with the fact that in the dist, the main file is react-final-form.cjs.js. I think this may mean that the .flow file that gets generated may need to be called react-final-form.cjs.js.flow. When I renamed index.js.flow to react-final-form.cjs.js, flow seems to work:

---

NOTE: The types still seem to be problematic however. When I use the simple example (only thing I changed was <Styles> to <div>), there seem to be all sorts of Flow errors. I'm not sure if this has to do with the type definitions being incorrect or not.

Example Code: Gist
Terminal Output: Gist

[zalishchuk]

@erikras I also can't get flow typings to work.

import type { FieldRenderProps /* any */ } from 'react-final-form';

Only thing worked for me is to specify typings path:

import type { FieldRenderProps /* FieldRenderProps */ } from 'react-final-form/dist/types.js.flow';

[erikras]

I've been investigating this. @saadq's analysis was exactly correct.

The other stuff seems to be caused by the latest version of Flow. Still investigating...

[erikras]

Should be fixed in final-form@4.3.0 and react-final-form@3.1.3.

[consegrado]

@erikras there is no export of type FieldRenderProps

[StevenLangbroek]

Having the same issue as @consegrado. Any idea @erikras? If i look at the definitions I definitely see it there, but flow (I tried 0.63 and 0.68) both seem to think it's not there.

[erikras]

@StevenLangbroek Check out v3.1.5. It publishes all those other types.

[StevenLangbroek]

Like a charm :) amazing work as per usual!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.