Skip to content

Conversation

@erikras
Copy link
Member

@erikras erikras commented Dec 6, 2017

Reverts #43. Changed my mind again. 🙈

Closes #41.

@erikras erikras merged commit c8eb275 into master Dec 6, 2017
@codecov
Copy link

codecov bot commented Dec 6, 2017

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #44   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         139    143    +4     
  Branches       38     41    +3     
=====================================
+ Hits          139    143    +4
Impacted Files Coverage Δ
src/FormSpy.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13032e...97e8470. Read the comment docs.

@philholden
Copy link

Thanks for doing so quickly, any chance of a release? My hacky use of the render function is breaking down now I need to setState(). Cannot initiate setState from render (infinite loop).

@erikras
Copy link
Member Author

erikras commented Dec 8, 2017

Yep! v1.2.0.

@philholden
Copy link

Thanks.

@erikras erikras deleted the revert-43-revert-42-formspy-onchange branch December 13, 2017 20:14
@lock
Copy link

lock bot commented May 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants