Generate RTFNotes from Notes during build process #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I'll submit a separate PR for the library function I'm working on to display |
|
Oh, I forgot to add pandoc to the GitHub runner. That'll be the next commit. |
|
This PR can't be merged at the moment. |
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically hooked into the class that injects the
HashURLso that it also injectsRTFNotes. And the design is a little more modular now, so we can more easily inject other elements in the future, if needed.I confirmed locally that dist files built in this branch differ from master only by the presence of
RTFNotes(where appropriate) and the lack of whitespace mangling inplugindef.I'm happy for any suggestions or questions.